Re: [PATCH 03/13] MM: reclaim mustn't enter FS for swap-over-NFS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: NeilBrown <neilb@xxxxxxx>
Subject: Re: [PATCH 03/13] MM: reclaim mustn't enter FS for swap-over-NFS
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 16 Nov 2021 21:50:25 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>, Anna Schumaker <anna.schumaker@xxxxxxxxxx>, Chuck Lever <chuck.lever@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Mel Gorman <mgorman@xxxxxxx>, linux-nfs@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <163709852340.13692.16362531894844686350@noble.neil.brown.name>
References: <163702956672.25805.16457749992977493579.stgit@noble.brown> <163703064452.25805.16932817889703270242.stgit@noble.brown> <YZNss/ujX3yovr/k@infradead.org> <163709852340.13692.16362531894844686350@noble.neil.brown.name>

On Wed, Nov 17, 2021 at 08:35:23AM +1100, NeilBrown wrote:
> +	/* We can "enter_fs" for swap-cache with only __GFP_IO

normal kernel style would be the

	/*

on a line of it's own.  But except for this nitpick this looks good.

References:
- [PATCH 00/13] Repair SWAP-over-NFS
  - From: NeilBrown
- [PATCH 03/13] MM: reclaim mustn't enter FS for swap-over-NFS
  - From: NeilBrown
- Re: [PATCH 03/13] MM: reclaim mustn't enter FS for swap-over-NFS
  - From: Christoph Hellwig
- Re: [PATCH 03/13] MM: reclaim mustn't enter FS for swap-over-NFS
  - From: NeilBrown

Prev by Date: Re: [PATCH 02/13] NFS: do not take i_rwsem for swap IO
Next by Date: Re: [PATCH v6] hugetlb: Add hugetlb.*.numa_stat file
Previous by thread: Re: [PATCH 03/13] MM: reclaim mustn't enter FS for swap-over-NFS
Next by thread: Re: [PATCH 03/13] MM: reclaim mustn't enter FS for swap-over-NFS
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]