Re: [PATCH v1 1/1] printk: Remove printk.h inclusion in percpu.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri 2021-11-12 13:15:51, Dennis Zhou wrote:
> On Fri, Nov 12, 2021 at 04:07:49PM +0200, Andy Shevchenko wrote:
> > After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk
> > in NMI") the printk.h is not needed anymore in percpu.h.
> > 
> > Moreover `make headerdep` complains (an excerpt)
> > 
> > In file included from linux/printk.h,
> >                  from linux/dynamic_debug.h:188
> >                  from linux/printk.h:559 <-- here
> >                  from linux/percpu.h:9
> >                  from linux/idr.h:17
> > include/net/9p/client.h:13: warning: recursive header inclusion
> > 
> > Yeah, it's not a root cause of this, but removing will help to reduce
> > the noise.
> > 
> > Fixes: 42a0bb3f7138 ("printk/nmi: generic solution for safe printk
> > in NMI")

Yup, the include was there because of printk_func_t definition that
was removed by the above commit.

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

> Hey Andrew, it doesn't seem like I have anything big coming through
> percpu, do you mind taking this. I might have some stuff due to sh, but
> I'm still working on that with them.

I assume that either Andrew or Dennis will take this patch.

Best Regards,
Petr




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux