Hello,
On Fri, Nov 12, 2021 at 04:07:49PM +0200, Andy Shevchenko wrote:
> After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk
> in NMI") the printk.h is not needed anymore in percpu.h.
>
> Moreover `make headerdep` complains (an excerpt)
>
> In file included from linux/printk.h,
> from linux/dynamic_debug.h:188
> from linux/printk.h:559 <-- here
> from linux/percpu.h:9
> from linux/idr.h:17
> include/net/9p/client.h:13: warning: recursive header inclusion
>
> Yeah, it's not a root cause of this, but removing will help to reduce
> the noise.
>
> Fixes: 42a0bb3f7138 ("printk/nmi: generic solution for safe printk in NMI")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> include/linux/percpu.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/percpu.h b/include/linux/percpu.h
> index 98a9371133f8..ae4004e7957e 100644
> --- a/include/linux/percpu.h
> +++ b/include/linux/percpu.h
> @@ -6,7 +6,6 @@
> #include <linux/preempt.h>
> #include <linux/smp.h>
> #include <linux/cpumask.h>
> -#include <linux/printk.h>
> #include <linux/pfn.h>
> #include <linux/init.h>
>
> --
> 2.33.0
>
Acked-by: Dennis Zhou <dennis@xxxxxxxxxx>
Hey Andrew, it doesn't seem like I have anything big coming through
percpu, do you mind taking this. I might have some stuff due to sh, but
I'm still working on that with them.
Thanks,
Dennis
