On 10/14/21 17:11, Michal Hocko wrote:
On Thu 14-10-21 15:58:29, Aneesh Kumar K.V wrote:
On 10/14/21 15:08, Michal Hocko wrote:
[...]
Besides that it would be really great to finish the discussion about the
usecase before suggesting a new userspace API.
Application would like to hint a preferred node for allocating memory
backing a va range and at the same time wants to avoid fallback to some set
of nodes (in the use case I am interested don't fall back to slow memory
nodes).
We do have means for that, right? You can set your memory policy and
then set the cpu afffinity to the node you want to allocate from
initially. You can migrate to a different cpu/node if this is not the
preferred affinity. Why is that not usable?
For the same reason you mentioned earlier, these nodes can be cpu less
nodes.
Also think about extensibility. Say I want to allocate from a set of
nodes first before falling back to the rest of the nodemask? If you want
to add a new API then think of other potential usecases.
Describing the specific allocation details become hard with preferred
node being a nodemask. With the below interface
SYSCALL_DEFINE5(preferred_mbind, unsigned long, start, unsigned long, len,
const unsigned long __user *, preferred_nmask, const unsigned long
__user *, fallback_nmask,
unsigned long, maxnode)
{
1. The preferred node is the first node in the preferred node mask
2. Then we try to allocate from nodes present in the preferred node mask
which is closer to the first node in the preferred node mask
3. If the above fails, we try to allocate from nodes in the fallback
node mask which is closer to the first node in the preferred nodemask.
Isn't that too complicated? Do we have a real usecase for that?
-aneesh
