Re: [patch 092/147] mtd/drivers/nand: use HZ macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrew,

akpm@xxxxxxxxxxxxxxxxxxxx wrote on Tue, 07 Sep 2021 19:58:11 -0700:

> From: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Subject: mtd/drivers/nand: use HZ macros
> 
> HZ unit conversion macros are available in units.h, use them and remove
> the duplicate definition.
> 
> Link: https://lkml.kernel.org/r/20210816114732.1834145-10-daniel.lezcano@xxxxxxxxxx
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Acked-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Cc: Christian Eggers <ceggers@xxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>
> Cc: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
> Cc: Lukasz Luba <lukasz.luba@xxxxxxx>
> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
> Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> Cc: Peter Meerwald <pmeerw@xxxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
> Cc: Zhang Rui <rui.zhang@xxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

A better suffix would have been "mtd: rawnand: intel:". Maybe you can
fix it when applying.

Acked-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

> ---
> 
>  drivers/mtd/nand/raw/intel-nand-controller.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/mtd/nand/raw/intel-nand-controller.c~mtd-drivers-nand-use-hz-macros
> +++ a/drivers/mtd/nand/raw/intel-nand-controller.c
> @@ -20,6 +20,7 @@
>  #include <linux/sched.h>
>  #include <linux/slab.h>
>  #include <linux/types.h>
> +#include <linux/units.h>
>  #include <asm/unaligned.h>
>  
>  #define EBU_CLC			0x000
> @@ -102,7 +103,6 @@
>  
>  #define MAX_CS	2
>  
> -#define HZ_PER_MHZ	1000000L
>  #define USEC_PER_SEC	1000000L
>  
>  struct ebu_nand_cs {
> _


Thanks,
Miquèl





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux