> > + ret = 0; > > + if (!ret) > > + break; > > Shouldn't that read: > if (ret) > break; > > So that we bail when there's a real error instead of no error? > Right, will fix this and also do the PTR_ERR changes that you suggested. -- thanks and regards Srikar -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>