On Wed, 2011-11-23 at 17:09 +0100, Peter Zijlstra wrote: > > + if (IS_ERR(vi)) { > > + ret = -ENOMEM; > > + break; > > + } Also, might as well use: ret = PTR_ERR(vi); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href