On Mon, Aug 16, 2021 at 05:05:10PM -0700, Andrew Morton wrote:
> On Mon, 16 Aug 2021 16:35:02 +0300 Mike Rapoport <rppt@xxxxxxxxxx> wrote:
>
> > From: Mike Rapoport <rppt@xxxxxxxxxxxxx>
> >
> > Add missing names of __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON flags to
> > __def_gfpflag_names.
> >
> > Fixes: 013bb59dbb7c ("arm64: mte: handle tags zeroing at page allocation time")
> > Fixes: c275c5c6d50a ("kasan: disable freed user page poisoning with HW tags")
>
> "fixes" in what way? ie, what problems were caused by the above commits?
>
> > --- a/include/trace/events/mmflags.h
> > +++ b/include/trace/events/mmflags.h
> > @@ -48,7 +48,9 @@
> > {(unsigned long)__GFP_WRITE, "__GFP_WRITE"}, \
> > {(unsigned long)__GFP_RECLAIM, "__GFP_RECLAIM"}, \
> > {(unsigned long)__GFP_DIRECT_RECLAIM, "__GFP_DIRECT_RECLAIM"},\
> > - {(unsigned long)__GFP_KSWAPD_RECLAIM, "__GFP_KSWAPD_RECLAIM"}\
> > + {(unsigned long)__GFP_KSWAPD_RECLAIM, "__GFP_KSWAPD_RECLAIM"},\
> > + {(unsigned long)__GFP_ZEROTAGS, "__GFP_ZEROTAGS"}, \
> > + {(unsigned long)__GFP_SKIP_KASAN_POISON,"__GFP_SKIP_KASAN_POISON"}\
> >
> > #define show_gfp_flags(flags) \
> > (flags) ? __print_flags(flags, "|", \
>
> I'm guessing that the tracing output was messed up in some fashion?
I didn't check tracing actually, but printk("%pGg") outputs these two flags
as hexadecimal number, rather that string, e.g:
GFP_KERNEL|0x1800000
--
Sincerely yours,
Mike.
