> -----Original Message-----
> From: Jane Chu <jane.chu@xxxxxxxxxx>
> Subject: Re: [PATCH RESEND v6 2/9] dax: Introduce holder for dax_device
>
>
> On 7/30/2021 3:01 AM, Shiyang Ruan wrote:
> > --- a/drivers/dax/super.c
> > +++ b/drivers/dax/super.c
> > @@ -214,6 +214,8 @@ enum dax_device_flags {
> > * @cdev: optional character interface for "device dax"
> > * @host: optional name for lookups where the device path is not available
> > * @private: dax driver private data
> > + * @holder_rwsem: prevent unregistration while holder_ops is in progress
> > + * @holder_data: holder of a dax_device: could be filesystem or mapped
> device
> > * @flags: state and boolean properties
>
> Perhaps add two documentary lines for @ops and @holder_ops?
OK. I'll add them in next version.
--
Thanks,
Ruan.
> > */
> > struct dax_device {
> > @@ -222,8 +224,11 @@ struct dax_device {
> > struct cdev cdev;
> > const char *host;
> > void *private;
> > + struct rw_semaphore holder_rwsem;
> > + void *holder_data;
> > unsigned long flags;
> > const struct dax_operations *ops;
> > + const struct dax_holder_operations *holder_ops;
> > };
>
> thanks,
> -jane
