On Tue, Aug 10, 2021 at 07:08:58AM -0700, Dave Hansen wrote: > On 8/9/21 11:26 PM, Kirill A. Shutemov wrote: > > UEFI Specification version 2.9 introduces concept of memory acceptance: > > Some Virtual Machine platforms, such as Intel TDX or AMD SEV-SNP, > > requiring memory to be accepted before it can be used by the guest. > > Accepting happens via a protocol specific for the Virtrual Machine > > platform. > > > > Accepting memory is costly and it makes VMM allocate memory for the > > accepted guest physical address range. We don't want to accept all memory > > upfront. > > This could use a bit more explanation. Any VM is likely to *eventually* > touch all its memory, so it's not like a VMM has a long-term advantage > by delaying this. > > So, it must have to do with resource use at boot. Is this to help boot > times? Yes, boot time is main motivation. But I'm going also to look at long-term VM behaviour with the fixed memory footprint. I think if a workload allocate/free memory within the same amount we can keep memory beyond the size unaccepted. Few tweaks likely will be required such as disabling page shuffling on free to keep unaccepted memory at the tail of free list. More investigation needed. > I had expected this series, but I also expected it to be connected to > CONFIG_DEFERRED_STRUCT_PAGE_INIT somehow. Could you explain a bit how > this problem is different and demands a totally orthogonal solution? > > For instance, what prevents us from declaring: "Memory is accepted at > the time that its 'struct page' is initialized" ? Then, we use all the > infrastructure we already have for DEFERRED_STRUCT_PAGE_INIT. That was my first thought too and I tried it just to realize that it is not what we want. If we would accept page on page struct init it means we would make host allocate all memory assigned to the guest on boot even if guest actually use small portion of it. Also deferred page init only allows to scale memory accept across multiple CPUs, but doesn't allow to get to userspace before we done with it. See wait_for_completion(&pgdat_init_all_done_comp). -- Kirill A. Shutemov
