On Tue, Aug 10, 2021 at 7:43 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > On Tue, 10 Aug 2021 16:23:52 +0200 Jesper Dangaard Brouer wrote: > > On 10/08/2021 16.01, Jakub Kicinski wrote: > > > On Fri, 6 Aug 2021 10:46:18 +0800 Yunsheng Lin wrote: > > >> enable skb's page frag recycling based on page pool in > > >> hns3 drvier. > > > > > > Applied, thanks! > > > > I had hoped to see more acks / reviewed-by before this got applied. > > E.g. from MM-people as this patchset changes struct page and page_pool > > (that I'm marked as maintainer of). > > Sorry, it was on the list for days and there were 7 or so prior > versions, I thought it was ripe. If possible, a note that review > will come would be useful. > > > And I would have appreciated an reviewed-by credit to/from Alexander > > as he did a lot of work in the RFC patchset for the split-page tricks. > > I asked him off-list, he said something I interpreted as "code is okay, > but the review tag is not coming". Yeah, I ran out of feedback a revision or two ago and just haven't had a chance to go through and add my reviewed by. If you want feel free to add my reviewed by for the set. Reviewed-by: Alexander Duyck <alexanderduyck@xxxxxx>