On Thu, Jun 24, 2021 at 07:20:12PM +0100, Matthew Wilcox wrote: > > While this looks good, I think the whole abstraction is wrong. I think > > test_clear_page_writeback should just be merged into it's only caller. > > I'm not opposed to doing that, but something else has to get > un-static'ed in order to make that happen. > > folio_end_writeback (exported, filemap.c) > -> folio_wake (static, filemap.c) > -> folio_wake_bit (static, filemap.c) > -> __folio_end_writeback (non-static, page-writeback.c) > -> __wb_writeout_add (static, page-writeback.c) > > I'm not sure there's an obviously better split than where it is right > now. Ok, let's ignore that whole mess for now. There is plenty bigger fish to fry.
