On Thu, Jun 24, 2021 at 07:02:23PM +0100, Matthew Wilcox wrote:
> > What is the advantage of copying backwards here to start with?
>
> Easier to write the loop this way? I suppose we could do it as ...
>
> unsigned int i, nr = folio_nr_pages(folio);
>
> for (i = 0; i < nr; i++) {
> /* folio_page() handles discontinuities in memmap */
> copy_highpage(folio_page(newfolio, i), folio_page(folio, i));
> cond_resched();
> }
I'd prefer that if there is no obvious downside.
