Hello Peter, Thank you for looking at this patch set! * Peter Zijlstra <peterz@xxxxxxxxxxxxx> [210514 06:41]: > On Wed, Apr 28, 2021 at 03:36:02PM +0000, Liam Howlett wrote: > > > +/* Flags: > > + * MAPLE_ALLOC_RANGE Use allocation ranges (tracks gaps) in this tree > > + * MAPLE_USE_RCU Operate in read/copy/update mode for multi-readers. > > + * MAPLE_HEIGHT_OFFSET The position of the tree height in the flags > > + * MAPLE_HEIGHT_MASK The mask for the maple tree height value. > > + */ > > Regular comment style would be: > > /* > * Flags: > ... > */ I will fix this. > > > +#define MAPLE_ALLOC_RANGE 1 // Bit 0 > > +#define MAPLE_USE_RCU 2 // Bit 1 > > +#define MAPLE_HEIGHT_OFFSET 2 // Bit 2 > > +#define MAPLE_HEIGHT_MASK 60 // Bits 2-5 > > Can we pretty please keep masks in hex, like: > > #define MAPLE_HEIGHT_MASK 0x3c > > Because then it's instantly obvious is it bits 2-5. > Sure, I will change them all to two digit hex so they align. I should probably check that whitespace too.
