On Fri, 23 Apr 2021, Andrew Morton wrote: > On Fri, 23 Apr 2021 10:22:51 -0700 (PDT) Hugh Dickins <hughd@xxxxxxxxxx> wrote: > > On Thu, 22 Apr 2021, Andrew Morton wrote: > > > On Thu, 22 Apr 2021 13:48:57 -0700 (PDT) Hugh Dickins <hughd@xxxxxxxxxx> wrote: > > > > > > > Andrew, I'd have just sent a -fix.patch to remove the unnecessary u64s, > > > > but need to reword the commit message: so please replace yesterday's > > > > mm-filemap-fix-mapping_seek_hole_data-on-thp-32-bit.patch > > > > by this one - thanks. > > > > > > Actually, I routinely update the base patch's changelog when queueing a -fix. > > > > And thank you for that, but if there's time, I think we would still > > prefer the final commit message to include corrections where Matthew > > enlightened me (that "sign-extension" claim came from my confusion): > > That's my point. When I merge a -v2 as a -fix, I replace the v1 > patch's changelog with v2's changelog so everything works out after > folding. Oh, great, thanks: that was not clear to me, I feared you meant adding "v2: remove unneeded u64 casts" to v1 when merging. Hugh
