On 10/06, Srikar Dronamraju wrote: > > * Oleg Nesterov <oleg@xxxxxxxxxx> [2011-10-05 20:50:08]: > > yes we might be doing an unnecessary __register_uprobe() but because it > raced with unregister_uprobe() and got the lock, we would avoid doing a > __unregister_uprobe(). > > However I am okay to move the lock before del_consumer(). To me this looks a bit "safer" even if currently __register is idempotent. But, > Please let me > know how you prefer this. No, no, Srikar. Please do what you prefer. You are the author. And btw I forgot to mention that initially I wrongly thought this is buggy. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>