On 10/05, Srikar Dronamraju wrote: > > * Oleg Nesterov <oleg@xxxxxxxxxx> [2011-10-03 18:29:05]: > > > But I am starting to think I simply do not understand this change. > > To the point, I do not underestand why do we need copy_insn() at all. > > We are going to replace this page, can't we save/analyze ->insn later > > when we copy the content of the old page? Most probably I missed > > something simple... > > > > Copying the instruction at the time we replace the original instruction > would have been ideal. However there are a few irritants to handle. > > ... > How do we distinguish if the > breakpoint instruction was around in the text or somebody inserted a > breakpoint in that address-space? Since we read from the page-cache, > we can easily resolve this. Ah. I see. > - On archs like x86, with variable size instructions, the original > instruction can be across 2 pages. Heh. Indeed ;) Thanks Srikar. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>