On Fri, Feb 19, 2021 at 11:50 PM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > (There is a separate warning flag for broken header guards, > -Wheader-guard: > https://github.com/ClangBuiltLinux/linux/issues?q=is%3Aissue+label%3A-Wheader-guard+is%3Aclosed) Yeah, this would still help cases with headers without guards (not really common, but...). > What happens should the kernel move to gnu11, as discussed once GCC > 5.1+ becomes the minimum supported version for all arches? > https://lore.kernel.org/lkml/CAHk-=whnKkj5CSbj-uG_MVVUsPZ6ppd_MFhZf_kpXDkh2MAVRA@xxxxxxxxxxxxxx/ > > Then the warning will not fire, since it's only really meant to help C > code be portable between -std=c11. I think it is a fine warning to keep in the compiler nevertheless since you already have it, even if disabled by default or only in -Wextra or something like that -- e.g. I would use it in my own projects since I never intend to redefine a typedef. > https://lore.kernel.org/linux-mm/20210215204909.3824509-1-willy@xxxxxxxxxxxxx/ Thanks for the link! Cheers, Miguel
