On Fri, Feb 19, 2021 at 10:45 PM 'Nick Desaulniers' via Clang Built Linux <clang-built-linux@xxxxxxxxxxxxxxxx> wrote: > > That said, I'm fine disabling this warning; there's a separate error > for redefining a typedef to a different underlying type. That's > what's useful IMO, this one really is not. > > This warning doesn't really provide any value to us in the kernel; I > would guess the intent was to be helpful to code expected to be > portable across different -std=* It seems it would also be useful to sport unintended cases, e.g.: - Collisions on short identifiers (that by chance typedef to the same type). - Copy-pasting and forgetting to remove the original definition (i.e. it should have be cut-pasting instead). - Double inclusion of headers (with missing or broken #ifdef guards). Those may be providing value in the kernel. In particular, if we don't see any warning at the moment, it means those cases are not happening now anywhere, so we would be weakening things. Having said that, I don't see the original patch, so perhaps I am missing something. Cheers, Miguel
