On Tue 13-09-11 15:55:31, Kautuk Consul wrote:
> The ret variable is really not needed in mm_take_all_locks as per
> the current flow of the mm_take_all_locks function.
>
> So, eliminating this return variable.
>
> Signed-off-by: Kautuk Consul <consul.kautuk@xxxxxxxxx>
The compiled code seems to be very same - compilers are clever enough to
reorganize the code but anyway the code reads better this way.
Reviewed-by: Michal Hocko <mhocko@xxxxxxx>
> ---
> mm/mmap.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index a65efd4..48bc056 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -2558,7 +2558,6 @@ int mm_take_all_locks(struct mm_struct *mm)
> {
> struct vm_area_struct *vma;
> struct anon_vma_chain *avc;
> - int ret = -EINTR;
>
> BUG_ON(down_read_trylock(&mm->mmap_sem));
>
> @@ -2579,13 +2578,12 @@ int mm_take_all_locks(struct mm_struct *mm)
> vm_lock_anon_vma(mm, avc->anon_vma);
> }
>
> - ret = 0;
> + return 0;
>
> out_unlock:
> - if (ret)
> - mm_drop_all_locks(mm);
> + mm_drop_all_locks(mm);
>
> - return ret;
> + return -EINTR;
> }
>
> static void vm_unlock_anon_vma(struct anon_vma *anon_vma)
> --
> 1.7.6
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxx. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>