On Sun, Sep 18, 2011 at 05:40:11PM -0300, Glauber Costa wrote: > On 09/18/2011 05:39 PM, Kirill A. Shutemov wrote: > > On Sun, Sep 18, 2011 at 04:11:21PM -0300, Glauber Costa wrote: > >> On 09/18/2011 04:05 PM, Kirill A. Shutemov wrote: > >>> On Sun, Sep 18, 2011 at 12:39:12AM -0300, Glauber Costa wrote: > >>>>> Always zero in root cgroup? > >>>> > >>>> Yes, if we're not accounting, it should be zero. WARN_ON, maybe? > >>> > >>> -ENOSYS? > >>> > >> I'd personally prefer WARN_ON. It is good symmetry from userspace PoV to > >> always be able to get a value out of it. Also, it something goes wrong > >> and it is not zero for some reason, this will help us find it. > > > > What's the point to get non-relevant value? > > What about -ENOSYS + WARN_ON? > > > Well, > > what about not even registering kernel memory files for !root cgroup? ENOENT works for me ;) -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>