On Thu, Jan 14, 2021 at 10:01 AM Will Deacon <will@xxxxxxxxxx> wrote: > > Try to clean this up by splitting the immutable fault information out > into a new 'struct vm_fault_info' which is embedded in 'struct vm_fault' > and will later be made 'const'. The vast majority of this change was > performed with a coccinelle patch: You may have a reason for doing it this way, but my reaction to this was: "just make the new embedded struct unnamed". Then you wouldn't need to do all the automated coccinelle changes. Is there some reason you didn't do that, or just a "oh, I didn't think of it". Linus