Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andrea Arcangeli <aarcange@xxxxxxxxxx>
Subject: Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()
From: Hugh Dickins <hughd@xxxxxxxxxx>
Date: Wed, 6 Jan 2021 12:18:36 -0800 (PST)
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Hugh Dickins <hughd@xxxxxxxxxx>, Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx>, Minchan Kim <minchan@xxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <X/YY+mjpq15nmryI@redhat.com>
References: <1607743586-80303-1-git-send-email-alex.shi@linux.alibaba.com> <1607743586-80303-2-git-send-email-alex.shi@linux.alibaba.com> <e50574aa-87b8-8ddf-2235-ef98e22bcb7d@linux.alibaba.com> <alpine.LSU.2.11.2101051919130.1361@eggly.anvils> <20210106114620.5c221690f3a9cad7afcc3077@linux-foundation.org> <X/YY+mjpq15nmryI@redhat.com>
User-agent: Alpine 2.11 (LSU 23 2013-08-11)

On Wed, 6 Jan 2021, Andrea Arcangeli wrote:
> 
> I'd be surprised if the kernel can boot with BUG_ON() defined as "do
> {}while(0)" so I guess it doesn't make any difference.

I had been afraid of that too, when CONFIG_BUG is not set:
but I think it's actually "if (cond) do {} while (0)".

Follow-Ups:
- Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()
  - From: Vlastimil Babka
- Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()
  - From: Andrew Morton

References:
- [PATCH] mm/zsmalloc: replace if (cond) BUG() with BUG_ON()
  - From: Alex Shi
- [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()
  - From: Alex Shi
- Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()
  - From: Alex Shi
- Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()
  - From: Hugh Dickins
- Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()
  - From: Andrew Morton
- Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()
  - From: Andrea Arcangeli

Prev by Date: Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()
Next by Date: Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()
Previous by thread: Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()
Next by thread: Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]