Re: [PATCH] ARM: sparsemem: Enable CONFIG_HOLES_IN_ZONE config option for SparseMem and HAS_HOLES_MEMORYMODEL for linux-3.0.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mel,


Kautuk Consul <consul.kautuk <at> gmail.com> writes:

> 
> Ok, I analyzed the code and it seems that this alignment problem has
> been solved by the changes made
> to the free_unused_memmap() code in arch/arm/mm/init.c.
> 
> I backported those changes to free_unused_memmap_node() in
> linux-2.6.35.9 and I don't see any more
> crashes. This solves my problem.
> 
> Thanks for all the help.


As per the email below, you might remember that I found a temporary 
solution by back-porting the free_unused_memmap_node() function in the 
arch/arm code.

The original issue was a crash in the move_freepages() function. 
The crash was happening because the pageblock pages was partially 
within one memory bank.

Can we solve this issue by modifying the check in move_freepages_block()
in the following manner: 
if (end_pfn >= zone->zone_start_pfn + zone->spanned_pages || 
    !PageBuddy(end_page))
    return 0;

This should take care of the crash situation as we will return 0 if
the end_page is lying outside a valid memory bank.

Do you agree with this change ?


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]