On Wed, Nov 11, 2020 at 10:33:29AM +0100, Arnd Bergmann wrote: > On Tue, Nov 10, 2020 at 5:21 PM Mike Rapoport <rppt@xxxxxxxxxx> wrote: > > On Tue, Nov 10, 2020 at 12:21:11PM +0100, Arnd Bergmann wrote: > > > > > > To be on the safe side, we could provoke a compile-time error > > > when CONFIG_PHYS_ADDR_T_64BIT is set on a 32-bit > > > architecture, but MAX_POSSIBLE_PHYSMEM_BITS is not set. > > > > Maybe compile time warning and a runtime error in zs_init() if 32 bit > > machine has memory above 4G? > > If the fix is as easy as adding a single line in a header, I think a > compile-time > error makes it easier, no need to wait for someone to boot a broken > system before fixing it. Not sure it would be as easy as adding a single line in a header for MIPS with it's diversity. How about adding a runtime detection like Minchan suggested for !MEMORY_HOTPLUG (e.g. MIPS and ARC) and a compile time error otherwise (i386, ppc)? > Arnd -- Sincerely yours, Mike.
