Michal Hocko <mhocko@xxxxxxxx> wrote: > On Fri 09-10-20 09:51:04, Miaohe Lin wrote: >> The mz->usage_in_excess >= mz_node->usage_in_excess check is exactly >> the else case of mz->usage_in_excess < mz_node->usage_in_excess. So we >> could replace else if (mz->usage_in_excess >= >> mz_node->usage_in_excess) with else equally. >> >> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx> > >Acked-by: Michal Hocko <mhocko@xxxxxxxx> > >I believe this is a result of a very unreadable code. Resp. the comment makes it hard to follow. It would be slightly better to simply drop the comment which doesn't really explain much IMHO. > Agree. Will do it in v2. Many thanks.