On Sat, 25 Jul 2020, Hugh Dickins wrote: > On Sat, 25 Jul 2020, Linus Torvalds wrote: > > On Sat, Jul 25, 2020 at 3:14 AM Oleg Nesterov <oleg@xxxxxxxxxx> wrote: > > > > > > Heh. I too thought about this. And just in case, your patch looks correct > > > to me. But I can't really comment this behavioural change. Perhaps it > > > should come in a separate patch? > > > > We could do that. At the same time, I think both parts change how the > > waitqueue works that it might as well just be one "fix page_bit_wait > > waitqueue usage". > > > > But let's wait to see what Hugh's numbers say. > > Oh no, no no: sorry for getting your hopes up there, I won't come up > with any numbers more significant than "0 out of 10" machines crashed. > I know it would be *really* useful if I could come up with performance > comparisons, or steer someone else to do so: but I'm sorry, cannot. > > Currently it's actually 1 out of 10 machines crashed, for the same > driverland issue seen last time, maybe it's a bad machine; and another > 1 out of the 10 machines went AWOL for unknown reasons, but probably > something outside the kernel got confused by the stress. No reason > to suspect your changes at all (but some unanalyzed "failure"s, of > dubious significance, accumulating like last time). > > I'm optimistic: nothing has happened to warn us off your changes. Less optimistic now, I'm afraid. The machine I said had (twice) crashed coincidentally in driverland (some USB completion thing): that machine I set running a comparison kernel without your changes this morning, while the others still running with your changes; and it has now passed the point where it twice crashed before (the most troublesome test), without crashing. Surprising: maybe still just coincidence, but I must look closer at the crashes. The others have now completed, and one other crashed in that troublesome test, but sadly without yielding any crash info. I've just set comparison runs going on them all, to judge whether to take the "failure"s seriously; and I'll look more closely at them. But hungry and tired now: unlikely to have more to say tonight. > > And on Fri, 24 Jul 2020, Linus Torvalds had written: > > So the loads you are running are known to have sensitivity to this > > particular area, and are why you've done your patches to the page wait > > bit code? > > Yes. It's a series of nineteen ~hour-long tests, of which about five > exhibited wake_up_page_bit problems in the past, and one has remained > intermittently troublesome that way. Intermittently: usually it does > get through, so getting through yesterday and today won't even tell > us that your changes fixed it - that we shall learn over time later. > > Hugh
