On Thu, Jul 23, 2020 at 10:32 AM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> So here's a v2, now as a "real" commit with a commit message and everything.
Oh, except it's broken.
Switching from the "am I still on the list" logic to the
"WQ_FLAG_WOKEN is set if woken" logic was all well and good, but I
missed the case where we did that trylock_page_bit_common().
It used to just not add the thing to the list if it would get the page
bit, and then the rest of the waiting logic looked at that and was
happy.
But now if it needs to actually fake that WQ_FLAG_WOKEN flag.
So that patch needs to do something like this:
if (!trylock_page_bit_common(page, bit_nr, behavior))
__add_wait_queue_entry_tail(q, wait);
else
wait->flags |= WQ_FLAG_WOKEN;
in there. Or maybe have that bit set originally, and clear it when we
add to the wait queue.
I'll send a new version after I actually test it.
Linus
