On Fri, Jul 10, 2020 at 02:53:01PM +0100, Matthew Wilcox wrote: > On Fri, Jul 10, 2020 at 03:49:56PM +0200, Uladzislau Rezki wrote: > > > On Fri, Jul 10, 2020 at 08:17:52PM +0800, Tian Tao wrote: > > > > In fact "vmalloc=<size>" cmdline option is not available on many > > > > platforms.When the user encounters this error, add the correct > > > > hint to prevent misleading. > > > > > > i don't think this is an improvement. > > > > > Matthew, maybe it should not be considered as improvements? > > Every patch should be an improvement along some dimension. This doesn't > feel like an improvement in any way. > > > It is rather an extra information that indicates that your > > ARCH may not support "vmalloc" early parameter. > > If anything needs to be improved, it's the documentation, not this > error message. > As i mentioned before, i do not have a strong opinion about this patch. From the other hand improving that message looks normal to me. Especially in a context that it took a time to understand that ARM64 does not support it, so we have had a precedent. I am talking about author of this patch. -- Vlad Rezki
