Hi David > -----Original Message----- > From: David Hildenbrand <david@xxxxxxxxxx> > Sent: Thursday, July 9, 2020 5:19 PM > To: Mike Rapoport <rppt@xxxxxxxxxxxxx>; Matthew Wilcox > <willy@xxxxxxxxxxxxx> > Cc: Justin He <Justin.He@xxxxxxx>; Catalin Marinas > <Catalin.Marinas@xxxxxxx>; Will Deacon <will@xxxxxxxxxx>; Tony Luck > <tony.luck@xxxxxxxxx>; Fenghua Yu <fenghua.yu@xxxxxxxxx>; Yoshinori Sato > <ysato@xxxxxxxxxxxxxxxxxxxx>; Rich Felker <dalias@xxxxxxxx>; Dave Hansen > <dave.hansen@xxxxxxxxxxxxxxx>; Andy Lutomirski <luto@xxxxxxxxxx>; Peter > Zijlstra <peterz@xxxxxxxxxxxxx>; Thomas Gleixner <tglx@xxxxxxxxxxxxx>; > Ingo Molnar <mingo@xxxxxxxxxx>; Borislav Petkov <bp@xxxxxxxxx>; > x86@xxxxxxxxxx; H. Peter Anvin <hpa@xxxxxxxxx>; Dan Williams > <dan.j.williams@xxxxxxxxx>; Vishal Verma <vishal.l.verma@xxxxxxxxx>; Dave > Jiang <dave.jiang@xxxxxxxxx>; Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>; > Baoquan He <bhe@xxxxxxxxxx>; Chuhong Yuan <hslester96@xxxxxxxxx>; Logan > Gunthorpe <logang@xxxxxxxxxxxx>; Masahiro Yamada <masahiroy@xxxxxxxxxx>; > Michal Hocko <mhocko@xxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-ia64@xxxxxxxxxxxxxxx; linux- > sh@xxxxxxxxxxxxxxx; linux-nvdimm@xxxxxxxxxxxx; linux-mm@xxxxxxxxx; > Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>; Kaly Xin <Kaly.Xin@xxxxxxx> > Subject: Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in > arch specific directory > > On 09.07.20 11:18, Mike Rapoport wrote: > > On Thu, Jul 09, 2020 at 03:11:04AM +0100, Matthew Wilcox wrote: > >> On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: > >>> After a general version of __weak memory_add_physaddr_to_nid > implemented > >>> and exported , it is no use exporting twice in arch directory even if > >>> e,g, ia64/x86 have their specific version. > >>> > >>> This is to suppress the modpost warning: > >>> WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. > >>> Previous export was in vmlinux > >> > >> It's bad form to introduce a warning and then send a follow-up patch to > >> fix the warning. Just fold this patch into patch 1/6. > > > > Moreover, I think that patches 1-4 can be merged into one. > > > > +1 Okay, will update, thanks -- Cheers, Justin (Jia He)
