On 09.07.20 11:18, Mike Rapoport wrote: > On Thu, Jul 09, 2020 at 03:11:04AM +0100, Matthew Wilcox wrote: >> On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: >>> After a general version of __weak memory_add_physaddr_to_nid implemented >>> and exported , it is no use exporting twice in arch directory even if >>> e,g, ia64/x86 have their specific version. >>> >>> This is to suppress the modpost warning: >>> WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. >>> Previous export was in vmlinux >> >> It's bad form to introduce a warning and then send a follow-up patch to >> fix the warning. Just fold this patch into patch 1/6. > > Moreover, I think that patches 1-4 can be merged into one. > +1 -- Thanks, David / dhildenb
