On Tue, Jun 09, 2020 at 11:06:31AM -0700, Linus Torvalds wrote:
> On Tue, Jun 9, 2020 at 11:01 AM Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > Because right now it does something horribly horribly wrong if the
> > type of 'src' is at all different from the type of dst, or either of
> > them is different from 'type'
>
> Never mind, it's intentional, and the macro always uses 'type' for the
> access size. I guess I can see the reason for that, and despite the
> name it's more akin to the unsafe_copy_loop() helper than
> unsafe_get_user().
Yes. At least for now - I've not forgotten your ideas about a more
direct API. But for that I want to wait until:
a) all architectures actually use this scheme
b) find a user that cares enough about performance to bother with a
direct get/put scheme vs the copy calling conventons.
> The lack parentheses was a real issue, though.
Thanks for fixing it.
