Re: [patch 91/93] x86: use non-set_fs based maccess routines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 9, 2020 at 11:01 AM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Because right now it does something horribly horribly wrong if the
> type of 'src' is at all different from the type of dst, or either of
> them is different from 'type'

Never mind, it's intentional, and the macro always uses 'type' for the
access size. I guess I can see the reason for that, and despite the
name it's more akin to the unsafe_copy_loop() helper than
unsafe_get_user().

The lack parentheses was a real issue, though. And I still think it
_should_ have been more like unsafe_get_user(), since now it's
basically useless for anything but that copy loop.

                  Linus




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux