On Sunday, June 19, 2011, KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote: > On Mon, 20 Jun 2011 08:41:23 +0900 > KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote: > >> On Fri, 17 Jun 2011 15:04:18 -0700 >> Ying Han <yinghan@xxxxxxxxxx> wrote: >> >> > On Wed, Jun 15, 2011 at 8:53 PM, KAMEZAWA Hiroyuki >> > <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote: >> > > From e08990dd9ada13cf236bec1ef44b207436434b8e Mon Sep 17 00:00:00 2001 >> > > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> >> > > Date: Wed, 15 Jun 2011 14:11:01 +0900 >> > > Subject: [PATCH 3/7] memcg: add memory.scan_stat >> > > >> > > commit log of commit 0ae5e89 " memcg: count the soft_limit reclaim in..." >> > > says it adds scanning stats to memory.stat file. But it doesn't because >> > > we considered we needed to make a concensus for such new APIs. >> > > >> > > This patch is a trial to add memory.scan_stat. This shows >> > > - the number of scanned pages >> > > - the number of recleimed pages >> > > - the number of elaplsed time (including sleep/pause time) >> > > for both of direct/soft reclaim and shrinking caused by changing limit >> > > or force_empty. >> > > >> > > The biggest difference with oringinal Ying's one is that this file >> > > can be reset by some write, as >> > > >> > > # echo 0 ...../memory.scan_stat >> > > >> > > [kamezawa@bluextal ~]$ cat /cgroup/memory/A/memory.scan_stat >> > > scanned_pages_by_limit 358470 >> > > freed_pages_by_limit 180795 >> > > elapsed_ns_by_limit 21629927 >> > > scanned_pages_by_system 0 >> > > freed_pages_by_system 0 >> > > elapsed_ns_by_system 0 >> > > scanned_pages_by_shrink 76646 >> > > freed_pages_by_shrink 38355 >> > > elappsed_ns_by_shrink 31990670 >> > > total_scanned_pages_by_limit 358470 >> > > total_freed_pages_by_limit 180795 >> > > total_elapsed_ns_by_hierarchical 216299275 >> > > total_scanned_pages_by_system 0 >> > > total_freed_pages_by_system 0 >> > > total_elapsed_ns_by_system 0 >> > > total_scanned_pages_by_shrink 76646 >> > > total_freed_pages_by_shrink 38355 >> > > total_elapsed_ns_by_shrink 31990670 >> > > >> > > total_xxxx is for hierarchy management. >> > > >> > > This will be useful for further memcg developments and need to be >> > > developped before we do some complicated rework on LRU/softlimit >> > > management. >> > >> > Agreed. Actually we are also looking into adding a per-memcg API for >> > adding visibility of >> > page reclaim path. It would be helpful for us to settle w/ the API first. >> > >> > I am not a fan of names, but how about >> > "/dev/cgroup/memory/memory.reclaim_stat" ? >> > >> >> Hm, ok, I have no favorite. >> >> > > If I rename, I'll just rename file name as "reclaim_stat" but doesn't > rename internal structures because there is already "struct reclaim_stat". > > Hm, to be honest, I don't like the name "reclaim_stat". > (Because in most case, the pages are not freed for reclaim, but for > hitting limit.) > > memory.vmscan_info ? No objection on the name. I will look into the other part of the patch Thanks --ying > > Thanks, > -Kame > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href