On Mon, Jun 20, 2011 at 01:22:13PM +0800, Bob Liu wrote: > Function remap_pfn_range() means map physical address pfn<<PAGE_SHIFT to > user addr. > > For nommu arch it's implemented by vma->vm_start = pfn << PAGE_SHIFT which is > wrong acroding the original meaning of this function. > > Some driver developer using remap_pfn_range() with correct parameter will get > unexpected result because vm_start is changed. > > It should be implementd just like addr = pfn << PAGE_SHIFT which is meanless > on nommu arch, so this patch just make it simply return 0. I'd return -EINVAL if addr != pfn << PAGE_SHIFT. And I can imagine architectures wanting to do something with the prot flags. Daniel -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>