On Tue, 2011-06-07 at 18:29 +0530, Srikar Dronamraju wrote: > + up_write(&mm->mmap_sem); > + mutex_lock(&uprobes_mutex); > + down_read(&mm->mmap_sem); egads, and all that without a comment explaining why you think that is even remotely sane. I'm not at all convinced, it would expose the mmap() even though you could still decide to tear it down if this function were to fail, I bet there's some funnies there. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>