Hi Andrew and Lubomir, Thank you for the patch. On Mon, Apr 06, 2020 at 08:11:13PM -0700, Andrew Morton wrote: > From: Lubomir Rintel <lkundrak@xxxxx> > Subject: checkpatch: check proper licensing of Devicetree bindings > > According to Devicetree maintainers (see Link: below), the Devicetree > binding documents are preferrably licensed (GPL-2.0-only OR BSD-2-Clause). I think "preferrably" is a bit too weak: https://lore.kernel.org/lkml/CAL_JsqLYUooc-9i6U6Br9DQKPHZMrLJf3f883PeM4Ctbwycs8w@xxxxxxxxxxxxxx/ I'd thus use the error message level below, and s/should/shall/. Apart from that, Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Let's check that. The actual check is a bit more relaxed, to allow more > liberal but compatible licensing (e.g. GPL-2.0-or-later OR BSD-2-Clause). > > Link: https://lore.kernel.org/lkml/20200108142132.GA4830@bogus/ > Link: http://lkml.kernel.org/r/20200309215153.38824-1-lkundrak@xxxxx > Signed-off-by: Lubomir Rintel <lkundrak@xxxxx> > Acked-by: Joe Perches <joe@xxxxxxxxxxx> > Cc: Rob Herring <robh@xxxxxxxxxx> > Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > Cc: Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx>, > Cc: Jonas Karlman <jonas@xxxxxxxxx>, > Cc: Jernej Skrabec <jernej.skrabec@xxxxxxxx>, > Cc: Mark Rutland <mark.rutland@xxxxxxx>, > Cc: David Airlie <airlied@xxxxxxxx> > Cc: Daniel Vetter <daniel@xxxxxxxx>, > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > --- > > scripts/checkpatch.pl | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > --- a/scripts/checkpatch.pl~checkpatch-check-proper-licensing-of-devicetree-bindings > +++ a/scripts/checkpatch.pl > @@ -3157,6 +3157,17 @@ sub process { > WARN("SPDX_LICENSE_TAG", > "'$spdx_license' is not supported in LICENSES/...\n" . $herecurr); > } > + if ($realfile =~ m@^Documentation/devicetree/bindings/@ && > + not $spdx_license =~ /GPL-2\.0.*BSD-2-Clause/) { > + my $msg_level = \&WARN; > + $msg_level = \&CHK if ($file); > + if (&{$msg_level}("SPDX_LICENSE_TAG", > + > + "DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause)\n" . $herecurr) && > + $fix) { > + $fixed[$fixlinenr] =~ s/SPDX-License-Identifier: .*/SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)/; > + } > + } > } > } > } > _ -- Regards, Laurent Pinchart
