From: Jules Irenge <jbi.octave@xxxxxxxxx> Subject: mm/zsmalloc: add missing annotation for unpin_tag() Sparse reports a warning at unpin_tag()() warning: context imbalance in unpin_tag() - unexpected unlock The root cause is the missing annotation at unpin_tag() Add the missing __releases(bitlock) annotation Link: http://lkml.kernel.org/r/20200214204741.94112-14-jbi.octave@xxxxxxxxx Signed-off-by: Jules Irenge <jbi.octave@xxxxxxxxx> Acked-by: Minchan Kim <minchan@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/zsmalloc.c~mm-zsmalloc-add-missing-annotation-for-unpin_tag +++ a/mm/zsmalloc.c @@ -896,7 +896,7 @@ static void pin_tag(unsigned long handle bit_spin_lock(HANDLE_PIN_BIT, (unsigned long *)handle); } -static void unpin_tag(unsigned long handle) +static void unpin_tag(unsigned long handle) __releases(bitlock) { bit_spin_unlock(HANDLE_PIN_BIT, (unsigned long *)handle); } _
