From: Mateusz Nosek <mateusznosek0@xxxxxxxxx> Subject: mm/shmem.c: clean code by removing unnecessary assignment Previously 0 was assigned to variable 'error' but the variable was never read before reassignemnt later. So the assignment can be removed. Link: http://lkml.kernel.org/r/20200301152832.24595-1-mateusznosek0@xxxxxxxxx Signed-off-by: Mateusz Nosek <mateusznosek0@xxxxxxxxx> Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> Acked-by: Pankaj Gupta <pankaj.gupta.linux@xxxxxxxxx> Cc: Hugh Dickins <hughd@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/shmem.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) --- a/mm/shmem.c~mm-shmemc-clean-code-by-removing-unnecessary-assignment +++ a/mm/shmem.c @@ -3120,12 +3120,9 @@ static int shmem_symlink(struct inode *d error = security_inode_init_security(inode, dir, &dentry->d_name, shmem_initxattrs, NULL); - if (error) { - if (error != -EOPNOTSUPP) { - iput(inode); - return error; - } - error = 0; + if (error && error != -EOPNOTSUPP) { + iput(inode); + return error; } inode->i_size = len-1; _
