Re: [PATCH v2] mm/shuffle.c: Fix races in add_to_free_area_random()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: George Spelvin <lkml@xxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>
Subject: Re: [PATCH v2] mm/shuffle.c: Fix races in add_to_free_area_random()
From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Date: Tue, 17 Mar 2020 18:49:53 -0700
Cc: Dan Williams <dan.j.williams@xxxxxxxxx>, linux-mm@xxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
In-reply-to: <20200318014410.GA2281@SDF.ORG>
References: <20200317135035.GA19442@SDF.ORG> <202003171435.41F7F0DF9@keescook> <20200317230612.GB19442@SDF.ORG> <202003171619.23210A7E0@keescook> <20200318014410.GA2281@SDF.ORG>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

Hi,

On 3/17/20 6:44 PM, George Spelvin wrote:
> +	unsigned long r = READ_ONCE(rand), rshift = r << 1;;

don't need the double ending ;;

-- 
~Randy

References:
- [PATCH] mm/shuffle.c: optimize add_to_free_area_random()
  - From: George Spelvin
- Re: [PATCH] mm/shuffle.c: optimize add_to_free_area_random()
  - From: Kees Cook
- Re: [PATCH] mm/shuffle.c: optimize add_to_free_area_random()
  - From: George Spelvin
- Re: [PATCH] mm/shuffle.c: optimize add_to_free_area_random()
  - From: Kees Cook
- [PATCH v2] mm/shuffle.c: Fix races in add_to_free_area_random()
  - From: George Spelvin

Prev by Date: [PATCH v2] mm/shuffle.c: Fix races in add_to_free_area_random()
Next by Date: [v4 PATCH 1/2] mm: swap: make page_evictable() inline
Previous by thread: [PATCH v2] mm/shuffle.c: Fix races in add_to_free_area_random()
Next by thread: Re: [PATCH v2] mm/shuffle.c: Fix races in add_to_free_area_random()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux