On 03/14/20 at 01:56pm, Michal Hocko wrote: > On Sat 14-03-20 08:53:34, Baoquan He wrote: > > On 03/13/20 at 03:56pm, Michal Hocko wrote: > > > On Thu 12-03-20 22:17:49, Baoquan He wrote: > > > > This change makes populate_section_memmap()/depopulate_section_memmap > > > > much simpler. > > > > > > Not only and you should make it more explicit. It also tries to allocate > > > memmaps from the target numa node so this is a functional change. I > > > would prefer to have that in a separate patch in case we hit some weird > > > NUMA setups which would choke on memory less nodes and similar horrors. > > > > Yes, splitting sounds more reasonable, I would love to do that. One > > question is I noticed Andrew had picked this into -mm tree, if I post a > > new patchset including these two small patches, whether it's convenient > > to drop the old one and get these two merged. > > Andrew usually just drops the previous version and replaces it by the > new one. So just post a new version. Thanks! I see, will post a new version, thanks.