> > + */ > > +int uprobe_post_notifier(struct pt_regs *regs) > > +{ > > + struct uprobe *uprobe; > > + struct uprobe_task *utask; > > + > > + if (!current->mm || !current->utask || !current->utask->active_uprobe) > > + /* task is currently not uprobed */ > > + return 0; > > + > > + utask = current->utask; > > + uprobe = utask->active_uprobe; > > + if (!uprobe) > > + return 0; > > + > > + set_thread_flag(TIF_UPROBE); > > + return 1; > > +} > > Looks like this can be simplified. If current->utask->active_uprobe is > non-null then surely the assignment to uprobe will be too? > Yes, the two lines where we check for !uprobe and return are redundant and can be removed. Will be corrected in the next patchset. -- Thanks and Regards Srikar -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>