On 03/09/20 at 10:08am, David Hildenbrand wrote: > On 07.03.20 09:42, Baoquan He wrote: > > No functional change. > > > > Signed-off-by: Baoquan He <bhe@xxxxxxxxxx> > > --- > > mm/sparse.c | 134 +++++++++++++++++++++++++--------------------------- > > 1 file changed, 65 insertions(+), 69 deletions(-) > > IMHO, we don't need this patch - but just my personal opinion. Change > itself looks good on a quick glance. I personally like seeing function set operating on one data structure being put together. To me, I use vi+ctags+cscope to jump to called funtion easily. When try to get a picture of a data and handling, e.g here the subsection map and the relevant functions, putting them together is better to understand code. I am also fine to discard this patch, no patch has dependency on this one in this series, it's easy to not pick it if no one like it.
