> Note that drivers/gpu/drm/i915/i915_gem.c i915_gem_object_truncate() > calls the tmpfs ->truncate_range directly: update that in a separate > patch later, for now just let it duplicate the truncate_inode_pages(). > Because i915 handles unmap_mapping_range() itself at a different stage, > we have chosen not to bundle that into ->truncate_range. In your next series that makes it call the readpae replacement directly it might be nice to also call directly into shmem for hole punching. > I notice that ext4 is now joining ocfs2 and xfs in supporting fallocate > FALLOC_FL_PUNCH_HOLE: perhaps they should support truncate_range, and > tmpfs should support fallocate? But worry about that another time... No, truncate_range and the madvice interface are pretty sad hacks that should never have been added in the first place. Adding FALLOC_FL_PUNCH_HOLE support for shmem on the other hand might make some sense. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>