Re: [slubllv5 07/25] x86: Add support for cmpxchg_double

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/26/2011 02:25 PM, Eric Dumazet wrote:
>>
>> +#define cmpxchg16b(ptr, o1, o2, n1, n2)				\
>> +({								\
>> +	char __ret;						\
>> +	__typeof__(o2) __junk;					\
>> +	__typeof__(*(ptr)) __old1 = (o1);			\
>> +	__typeof__(o2) __old2 = (o2);				\
>> +	__typeof__(*(ptr)) __new1 = (n1);			\
>> +	__typeof__(o2) __new2 = (n2);				\
>> +	asm volatile(LOCK_PREFIX_HERE "lock; cmpxchg16b (%%rsi);setz %1" \
> 
> If there is no emulation, why do you force rsi here ?
> 
> It could be something else, like "=m" (*ptr) ?
> 
> (same remark for other functions)
> 

"+m" (*ptr) please...

	-hpa

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]