On Sun, May 22, 2011 at 3:25 PM, Hugh Dickins <hughd@xxxxxxxxxx> wrote: > > But drivers/gpu/drm i915 and ttm are using read_cache_page_gfp() or > read_mapping_page() on tmpfs: on objects created by shmem_file_setup(). > > Nothing else uses read_cache_page_gfp(). I cannot find anything else > using read_mapping_page() on tmpfs, but wonder if something might be > out there. Stacked filesystems appear not to go that way nowadays. > > Would it be better to make i915 and ttm call shmem_read_cache_page() > directly? Perhaps removing the then unused read_cache_page_gfp(), or > perhaps not: may still be needed for i915 and ttm on tiny !SHMEM ramfs. I would certainly prefer the "make i915 and ttm call shmem_read_cache_page directly" approach over putting some nasty hack in __read_cache_page. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href