On Wed, 18 May 2011 22:15:53 -0400 Andrew Lutomirski <luto@xxxxxxx> wrote: > On Wed, May 18, 2011 at 1:17 AM, Minchan Kim <minchan.kim@xxxxxxxxx> wrote: > > On Wed, May 18, 2011 at 4:22 AM, Andrew Lutomirski <luto@xxxxxxx> wrote: > > Andrew, Could you test this patch with !pgdat_balanced patch? > > I think we shouldn't see OOM message if we have lots of free swap space. > > > > == CUT_HERE == > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index f73b865..cc23f04 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -1341,10 +1341,6 @@ static inline bool > > should_reclaim_stall(unsigned long nr_taken, > > Â Â Â Âif (current_is_kswapd()) > > Â Â Â Â Â Â Â Âreturn false; > > > > - Â Â Â /* Only stall on lumpy reclaim */ > > - Â Â Â if (sc->reclaim_mode & RECLAIM_MODE_SINGLE) > > - Â Â Â Â Â Â Â return false; > > - > > Â Â Â Â/* If we have relaimed everything on the isolated list, no stall */ > > Â Â Â Âif (nr_freed == nr_taken) > > Â Â Â Â Â Â Â Âreturn false; > > > > > > > > Then, if you don't see any unnecessary OOM but still see the hangup, > > could you apply this patch based on previous? > > With this patch, I started GNOME and Firefox, turned on swap, and ran > test_mempressure.sh 1500 1400 1. Instant panic (or OOPS and hang or > something -- didn't get the top part). Picture attached -- it looks > like memcg might be involved. I'm running F15, so it might even be > doing something. > Hmm, what kernel version do you use ? I think memcg is not guilty because RIP is shrink_page_list(). But ok, I'll dig this. Could you give us your .config ? Thanks, -Kame > I won't be able to get netconsole dumps until next week because I'm > out of town and only have this one computer here. > > I haven't tried the other patch. > > Also, the !pgdat_balanced fix plus the if (need_resched()) return > false patch just hung once on 2.6.37-rc9. I don't know what triggered > it. Maybe yum. > > --Andy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>