On Fri, May 06, 2011 at 02:17:17PM -0700, Andi Kleen wrote: > From: Andi Kleen <ak@xxxxxxxxxxxxxxx> > > dde79e005a769 added a regression that the memory cgroup data structures > all end up in node 0 because the first attempt at allocating them > would not pass in a node hint. Since the initialization runs on CPU #0 > it would all end up node 0. This is a problem on large memory systems, > where node 0 would lose a lot of memory. > > Change the alloc_pages_exact to alloc_pages_exact_node. This will > still fall back to other nodes if not enough memory is available. > > [RED-PEN: right now it would fall back first before trying > vmalloc_node. Probably not the best strategy ... But I left it like > that for now.] > > v4: Remove debugging code. > v3: Really call the correct function now. Thanks for everyone who commented. > Reported-by: Doug Nelson > Cc: rientjes@xxxxxxxxxx > CC: Michal Hocko <mhocko@xxxxxxx> > Cc: Dave Hansen <dave@xxxxxxxxxxxxxxxxxx> > Cc: Balbir Singh <balbir@xxxxxxxxxx> > Cc: Johannes Weiner <hannes@xxxxxxxxxxx> > Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>