Re: [PATCHv2 57/59] x86/mktme: Document the MKTME Key Service API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx>
Subject: Re: [PATCHv2 57/59] x86/mktme: Document the MKTME Key Service API
From: Ben Boeckel <mathstuf@xxxxxxxxx>
Date: Mon, 5 Aug 2019 07:58:37 -0400
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxx>, Kai Huang <kai.huang@xxxxxxxxxxxxxxx>, Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>, Alison Schofield <alison.schofield@xxxxxxxxx>, linux-mm@xxxxxxxxx, kvm@xxxxxxxxxxxxxxx, keyrings@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "Kirill A . Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>
In-reply-to: <20190731150813.26289-58-kirill.shutemov@linux.intel.com>
References: <20190731150813.26289-1-kirill.shutemov@linux.intel.com> <20190731150813.26289-58-kirill.shutemov@linux.intel.com>
Reply-to: mathstuf@xxxxxxxxx
User-agent: Mutt/1.12.0 (2019-05-25)

On Wed, Jul 31, 2019 at 18:08:11 +0300, Kirill A. Shutemov wrote:
> +	key = add_key("mktme", "name", "no-encrypt", strlen(options_CPU),
> +		      KEY_SPEC_THREAD_KEYRING);

Should this be `type=no-encrypt` here? Also, seems like copy/paste from
the `type=cpu` case for the `strlen` call.

--Ben

Follow-Ups:
- Re: [PATCHv2 57/59] x86/mktme: Document the MKTME Key Service API
  - From: Alison Schofield

References:
- [PATCHv2 00/59] Intel MKTME enabling
  - From: Kirill A. Shutemov
- [PATCHv2 57/59] x86/mktme: Document the MKTME Key Service API
  - From: Kirill A. Shutemov

Prev by Date: Re: [PATCH STABLE 4.9] x86, mm, gup: prevent get_page() race with munmap in paravirt guest
Next by Date: Re: Let's talk about the elephant in the room - the Linux kernel's inability to gracefully handle low memory pressure
Previous by thread: [PATCHv2 57/59] x86/mktme: Document the MKTME Key Service API
Next by thread: Re: [PATCHv2 57/59] x86/mktme: Document the MKTME Key Service API
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]