Hi Rik, On Mon, May 2, 2011 at 11:57 PM, Rik van Riel <riel@xxxxxxxxxx> wrote: > On 05/01/2011 11:03 AM, Minchan Kim wrote: >> >> It's pointless that deactive_page's pagevec operation about >> unevictable page as it's nop. >> This patch removes unnecessary overhead which might be a bit problem >> in case that there are many unevictable page in system(ex, mprotect >> workload) >> >> Signed-off-by: Minchan Kim<minchan.kim@xxxxxxxxx> >> --- >> Âmm/swap.c | Â Â9 +++++++++ >> Â1 files changed, 9 insertions(+), 0 deletions(-) >> >> diff --git a/mm/swap.c b/mm/swap.c >> index 2e9656d..b707694 100644 >> --- a/mm/swap.c >> +++ b/mm/swap.c >> @@ -511,6 +511,15 @@ static void drain_cpu_pagevecs(int cpu) >> Â */ >> Âvoid deactivate_page(struct page *page) >> Â{ >> + >> + Â Â Â /* >> + Â Â Â Â* In workload which system has many unevictable page(ex, >> mprotect), >> + Â Â Â Â* unevictalge page deactivation for accelerating reclaim > > Typo. My bad. I will resend after work. Thanks. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href